feat: add get_member_info route#237
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new get_member_info route designed to retrieve simplified member information for portfolio display purposes. The implementation creates a separate module from the existing get_member route, following clean architecture patterns with distinct usecase, controller, viewmodel, and presenter layers.
Changes:
- Adds
GetMemberInfoUsecasethat retrieves basic member data and associated projects (without strike/action history complexity) - Adds
GetMemberInfoViewModelthat returns a simplified response with only portfolio-relevant fields - Registers the new Lambda function in infrastructure with GET method and proper authorization
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/get_member_info/app/get_member_info_viewmodel.py | Implements simplified viewmodel returning only portfolio fields (name, ra, role, stack, year, course, projects, hired_date, photo) |
| src/modules/get_member_info/app/get_member_info_usecase.py | Implements usecase that validates user, checks active status, and enriches member with project list |
| src/modules/get_member_info/app/get_member_info_presenter.py | Lambda handler that integrates with API Gateway authorizer for authentication |
| src/modules/get_member_info/app/get_member_info_controller.py | Controller handling request validation and error responses |
| tests/modules/get_member_info/app/test_get_member_info_viewmodel.py | Test file with critical issues: imports and tests reference wrong module (get_member instead of get_member_info) |
| tests/modules/get_member_info/app/test_get_member_info_usecase.py | Test file with critical issues: imports and tests reference wrong module with incorrect parameters |
| tests/modules/get_member_info/app/test_get_member_info_presenter.py | Test file with critical issues: imports wrong module, naming inconsistencies |
| tests/modules/get_member_info/app/test_get_member_info_controller.py | Test file with critical issues: imports wrong module, tests validate incorrect behavior |
| iac/iac/lambda_stack.py | Properly registers new get_member_info Lambda with GET method and adds to permission lists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lseixas
requested changes
Feb 27, 2026
lseixas
left a comment
lseixas
left a comment
Member
There was a problem hiding this comment.
boa, só falta adicionar a função pra dentro da lista de permissões no lambda stack
Member
|
@pleomoreno revisa os comentários do copilot tb e faz as alterações que ele ta pedindo |
lseixas
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.